dynamic-lambda: continue tracking the best proposal even after freezing#5701
Merged
dynamic-lambda: continue tracking the best proposal even after freezing#5701
Conversation
…specific to the msgp decoder
remove commented out code from when we were trying to get receivedAt for proposal-votes
fix comment to say validated instead of received
jasonpaulos
reviewed
Oct 6, 2023
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
cce
reviewed
Oct 11, 2023
gmalouf
previously approved these changes
Oct 11, 2023
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
The updated naming conventions made this noticeably easier to read/follow. There is a codegen failure to address on the build.
jannotti
reviewed
Oct 11, 2023
jannotti
reviewed
Oct 11, 2023
jasonpaulos
reviewed
Oct 11, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
LGTM -- it appears the build error is because msgp generation needs to be run again
jannotti
previously approved these changes
Oct 11, 2023
jasonpaulos
approved these changes
Oct 12, 2023
gmalouf
approved these changes
Oct 12, 2023
jannotti
approved these changes
Oct 12, 2023
cce
approved these changes
Oct 13, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #5654 and changes the credential propagation and tracking strategy, so we continue propagating credentials for some time after the round concluded and continue to track when we received the lowest credential. This makes the measurements for the dynamic lambda feature independent of the actual filter timeout being set.
Test Plan
Extending existing tests to make sure that better period 0 step 0 credentials get propagated even if they're late.
Extending existing tests to make sure that better period 0 step 0 credentials impact the measurements used in setting the filter timeout.